[Lldb-commits] [PATCH] D121036: Fix target.save-jit-objects when the CWD is not writeable

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Interpreter/OptionValue.h:314
   void SetValueChangedCallback(std::function<void()> callback) {
-    assert(!m_callback);
     m_callback = std::move(callback);
----------------
That's a weird assert


================
Comment at: lldb/source/Target/Target.cpp:4184
+  bool writable = llvm::sys::fs::can_write(path);
+  if (!exists || ! is_directory || !writable) {
+    m_collection_sp->GetPropertyAtIndex(nullptr, true, idx)->GetValue()
----------------
You could save a level of indentation by turning this into a return.


================
Comment at: lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py:41
         self.assertEquals(self.countJITFiles(), 0,
-                        "No files emitted with save-jit-objects=false")
-
-        self.runCmd("settings set target.save-jit-objects true")
+                        "No files emitted with save-jit-objects-dir empty")
+        
----------------



================
Comment at: lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py:48
         self.assertNotEqual(jit_files_count, 0,
-                        "At least one file emitted with save-jit-objects=true")
+                        "At least one file emitted with save-jit-objects-dir set to the build dir")
 
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121036/new/

https://reviews.llvm.org/D121036