[Lldb-commits] [PATCH] D120690: [PDB] Add char8_t type

[Zequan Wu via Phabricator via lldb-commits]

zequanwu added inline comments.


================
Comment at: lldb/include/lldb/lldb-enumerations.h:752
   eBasicTypeChar32,
+  eBasicTypeChar8,
   eBasicTypeShort,
----------------
ljmf00 wrote:
> You forgot to add it to the Python API. It should also be added at the end to avoid user-code breakage. See D116136 . I can rebase my change and correct this :)
Thanks, it sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120690/new/

https://reviews.llvm.org/D120690