[Lldb-commits] [lldb] 850bc76 - [lldb] BreakpointOptions::CommandData::CreateFromStructuredData - remove dead code + variable. NFCI.

[Simon Pilgrim via lldb-commits]

Author: Simon Pilgrim
Date: 2022-02-27T11:33:14Z
New Revision: 850bc76a356b050b92851ad5a6a8207da05685cd

URL: https://github.com/llvm/llvm-project/commit/850bc76a356b050b92851ad5a6a8207da05685cd
DIFF: https://github.com/llvm/llvm-project/commit/850bc76a356b050b92851ad5a6a8207da05685cd.diff

LOG: [lldb] BreakpointOptions::CommandData::CreateFromStructuredData - remove dead code + variable. NFCI.

The found_something bool is only ever read after it has always been set to true.

Looks to be a leftover debugging variable.

Fixes static analyzer warning: https://llvm.org/reports/scan-build/report-BreakpointOptions.cpp-CreateFromStructuredData-8-4055b9.html#EndPath

Added: 
    

Modified: 
    lldb/source/Breakpoint/BreakpointOptions.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Breakpoint/BreakpointOptions.cpp b/lldb/source/Breakpoint/BreakpointOptions.cpp
index 3dcb1904c8f8f..6fc6948aaccc2 100644
--- a/lldb/source/Breakpoint/BreakpointOptions.cpp
+++ b/lldb/source/Breakpoint/BreakpointOptions.cpp
@@ -60,14 +60,10 @@ std::unique_ptr<BreakpointOptions::CommandData>
 BreakpointOptions::CommandData::CreateFromStructuredData(
     const StructuredData::Dictionary &options_dict, Status &error) {
   std::unique_ptr<CommandData> data_up(new CommandData());
-  bool found_something = false;
 
   bool success = options_dict.GetValueForKeyAsBoolean(
       GetKey(OptionNames::StopOnError), data_up->stop_on_error);
 
-  if (success)
-    found_something = true;
-
   llvm::StringRef interpreter_str;
   ScriptLanguage interp_language;
   success = options_dict.GetValueForKeyAsString(
@@ -78,7 +74,6 @@ BreakpointOptions::CommandData::CreateFromStructuredData(
     return data_up;
   }
 
-  found_something = true;
   interp_language = ScriptInterpreter::StringToLanguage(interpreter_str);
   if (interp_language == eScriptLanguageUnknown) {
     error.SetErrorStringWithFormatv("Unknown breakpoint command language: {0}.",
@@ -91,7 +86,6 @@ BreakpointOptions::CommandData::CreateFromStructuredData(
   success = options_dict.GetValueForKeyAsArray(GetKey(OptionNames::UserSource),
                                                user_source);
   if (success) {
-    found_something = true;
     size_t num_elems = user_source->GetSize();
     for (size_t i = 0; i < num_elems; i++) {
       llvm::StringRef elem_string;
@@ -101,10 +95,7 @@ BreakpointOptions::CommandData::CreateFromStructuredData(
     }
   }
 
-  if (found_something)
-    return data_up;
-  else
-    return std::unique_ptr<BreakpointOptions::CommandData>();
+  return data_up;
 }
 
 const char *BreakpointOptions::g_option_names[(