[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

In D120284#3345994 <https://reviews.llvm.org/D120284#3345994>, @JDevlieghere wrote:

>> I'm not entirely sure what's the best fix here. @JDevlieghere, what do you think? Can we just remove the output arguments from the LLDB_INSTRUMENT_VA invocation (given how logging their entry values is pretty useless)?
>
> Yup, the way I dealt with that for the reproducers was initialize them before the macro, but no point in doing that purely for logging. Let's just remove the macro.
>
> I'll need to think of a way to avoid `lldb-instr` putting it back. It will ignore functions that start with a macro, so maybe we can add a NOOP macro "LLDB_NO_INSTRUMENT" or something?

Will `lldb-instr` try to override the macro if not all the function arguments are passed to the LLDB_INSTRUMENT_VA invocation ? If this is not the case, it should be fine for `SBDebugger::GetProgressFromEvent` since it still takes an SBEvent argument, that will remain in the LLDB_INSTRUMENT_VA invocation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120284/new/

https://reviews.llvm.org/D120284