[Lldb-commits] [PATCH] D120322: [lldb] Simplify HostThreadMacOSX

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 22 13:22:55 PST 2022


JDevlieghere added inline comments.


================
Comment at: lldb/source/Host/macosx/objcxx/HostThreadMacOSX.mm:17-20
+  NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+  lldb::thread_result_t result = HostThreadPosix::ThreadCreateTrampoline(arg);
+  [pool drain];
+  return result;
----------------
I believe it's recommended to use an @autoreleasepool block instead of using the NSAutoreleasePool directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120322/new/

https://reviews.llvm.org/D120322



More information about the lldb-commits mailing list