[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 3 inline comments as done.
mib added a comment.

@labath I addressed your comments in D120284 <https://reviews.llvm.org/D120284> :)



================
Comment at: lldb/bindings/interface/SBDebugger.i:126-129
+    %apply uint64_t& INOUT { uint64_t& progress_id };
+    %apply uint64_t& INOUT { uint64_t& completed };
+    %apply uint64_t& INOUT { uint64_t& total };
+    %apply bool& INOUT { bool& is_debugger_specific };
----------------
labath wrote:
> mib wrote:
> > @labath In my understanding, these tell SWIG to return return the reference values as a tuple. They are pre-pending the function return value. I'll write a follow-up patch to test it.
> Ah, that's cool. So it takes the `in` value as a regular argument, and provides the `out` value in the return value.
> 
> I don't suppose there's any chance of making this an `out`-only argument, to avoid the dummy input argument ?
I don't think SWIG offers such thing unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120100/new/

https://reviews.llvm.org/D120100