[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked an inline comment as done.
mib added inline comments.


================
Comment at: lldb/bindings/interface/SBDebugger.i:126-129
+    %apply uint64_t& INOUT { uint64_t& progress_id };
+    %apply uint64_t& INOUT { uint64_t& completed };
+    %apply uint64_t& INOUT { uint64_t& total };
+    %apply bool& INOUT { bool& is_debugger_specific };
----------------
@labath In my understanding, these tell SWIG to return return the reference values as a tuple. They are pre-pending the function return value. I'll write a follow-up patch to test it.


================
Comment at: lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py:22-23
+        listener = lldb.SBListener("lldb.progress.listener")
+        listener.StartListeningForEvents(test_broadcaster,
+                                         self.eBroadcastBitStopProgressThread)
+
----------------
labath wrote:
> There is a race here, where some (or even all) of the progress events will be generated before the listener actually starts listening for them. You need to ensure that the listener setup happens-before the events are generated. The easiest way to achieve that is to set up the listening on the main thread.
Thanks for catching that, I'll update the test.


================
Comment at: lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py:42
+
+    @skipUnlessDarwin
+    def test_dwarf_symbol_loading_progress_report(self):
----------------
labath wrote:
> Why?
So far, I know that Linux and macOS report some basic progress events when reading DWARF, but I'm not sure other platforms do, so I might be able to only skip windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120100/new/

https://reviews.llvm.org/D120100