[Lldb-commits] [PATCH] D119389: [lldb/crashlog] Add CrashLogScriptedProcess and resurrect_crashlog method

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:1098
 
+class ResurrectCrashProcess:
+    def __init__(self, debugger, internal_dict):
----------------
Do we need this at all if we integrate it in the existing crashlog command?


================
Comment at: lldb/examples/python/crashlog.py:1301-1302
         'command script add -c lldb.macosx.crashlog.Symbolicate crashlog')
+    debugger.HandleCommand(
+        'command script add -c lldb.macosx.crashlog.ResurrectCrashProcess resurrect_crashlog')
     debugger.HandleCommand(
----------------
I expect the scripted process implementation to take the place of the existing interactive mode (D119501) so I don't think we need a new command.


================
Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:12
+class CrashLogScriptedProcess(ScriptedProcess):
+    # NOTE: https://at.apple.com/json-crashlog-spec
+    def parse_crashlog(self):
----------------
This is an internal link :-) 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119389/new/

https://reviews.llvm.org/D119389