[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 10 22:09:24 PST 2022


mib added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:471
             exception_extra = ""
-        return "{} ({}){}".format(exception_type, exception_signal,
                                   exception_extra)
----------------
@JDevlieghere Here it's only prepended by a space, which is honored in my change since I concatenate `"({})".format(json_exception['signal'])` to `exception_signal` (which is initialized with a space).

I don't think this should have a trailing space because it's not guaranteed that we get something in `exception_extra`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119504/new/

https://reviews.llvm.org/D119504



More information about the lldb-commits mailing list