[Lldb-commits] [lldb] d327108 - [lldb/test] Split Scripted Process test in multiple tests (NFC)
Med Ismail Bennani via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 9 13:28:42 PST 2022
Author: Med Ismail Bennani
Date: 2022-02-09T13:28:20-08:00
New Revision: d327108d175fc5d1d4f5c018d129e337d162810c
URL: https://github.com/llvm/llvm-project/commit/d327108d175fc5d1d4f5c018d129e337d162810c
DIFF: https://github.com/llvm/llvm-project/commit/d327108d175fc5d1d4f5c018d129e337d162810c.diff
LOG: [lldb/test] Split Scripted Process test in multiple tests (NFC)
This splits the scripted process tests to be able to run in parallel
since some of test functions can take a very long time to run.
This also disables debug info testing.
Differential Revision: https://reviews.llvm.org/D118513
Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>
Added:
lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py
Modified:
lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
Removed:
################################################################################
diff --git a/lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py b/lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
index c8ce37c24d49..4f0981d8f3ac 100644
--- a/lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
+++ b/lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
@@ -2,7 +2,7 @@
Test python scripted process in lldb
"""
-import os, json, tempfile
+import os
import lldb
from lldbsuite.test.decorators import *
@@ -12,6 +12,8 @@
class ScriptedProcesTestCase(TestBase):
+ NO_DEBUG_INFO_TESTCASE = True
+
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
@@ -131,90 +133,3 @@ def cleanup():
break
self.assertEqual(idx, int(reg.value, 16))
- def create_stack_skinny_corefile(self, file):
- self.build()
- target, process, thread, _ = lldbutil.run_to_source_breakpoint(self, "// break here",
- lldb.SBFileSpec("main.cpp"))
- self.assertTrue(process.IsValid(), "Process is invalid.")
- # FIXME: Use SBAPI to save the process corefile.
- self.runCmd("process save-core -s stack " + file)
- self.assertTrue(os.path.exists(file), "No stack-only corefile found.")
- self.assertTrue(self.dbg.DeleteTarget(target), "Couldn't delete target")
-
- @skipUnlessDarwin
- @skipIf(archs=no_match(['arm64', 'arm64e']))
- @skipIfOutOfTreeDebugserver
- def test_launch_scripted_process_stack_frames(self):
- """Test that we can launch an lldb scripted process from the command
- line, check its process ID and read string from memory."""
- self.build()
- target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
- self.assertTrue(target, VALID_TARGET)
-
- for module in target.modules:
- if 'a.out' in module.GetFileSpec().GetFilename():
- main_module = module
- break
-
- self.assertTrue(main_module, "Invalid main module.")
- error = target.SetModuleLoadAddress(main_module, 0)
- self.assertTrue(error.Success(), "Reloading main module at offset 0 failed.")
-
- os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH'] = '1'
- def cleanup():
- del os.environ["SKIP_SCRIPTED_PROCESS_LAUNCH"]
- self.addTearDownHook(cleanup)
-
- scripted_process_example_relpath = 'stack_core_scripted_process.py'
- self.runCmd("command script import " + os.path.join(self.getSourceDir(),
- scripted_process_example_relpath))
-
- corefile_process = None
- with tempfile.NamedTemporaryFile() as file:
- self.create_stack_skinny_corefile(file.name)
- corefile_target = self.dbg.CreateTarget(None)
- corefile_process = corefile_target.LoadCore(self.getBuildArtifact(file.name))
- self.assertTrue(corefile_process, PROCESS_IS_VALID)
-
- structured_data = lldb.SBStructuredData()
- structured_data.SetFromJSON(json.dumps({
- "backing_target_idx" : self.dbg.GetIndexOfTarget(corefile_process.GetTarget())
- }))
- launch_info = lldb.SBLaunchInfo(None)
- launch_info.SetProcessPluginName("ScriptedProcess")
- launch_info.SetScriptedProcessClassName("stack_core_scripted_process.StackCoreScriptedProcess")
- launch_info.SetScriptedProcessDictionary(structured_data)
-
- error = lldb.SBError()
- process = target.Launch(launch_info, error)
- self.assertTrue(error.Success(), error.GetCString())
- self.assertTrue(process, PROCESS_IS_VALID)
- self.assertEqual(process.GetProcessID(), 42)
-
- self.assertEqual(process.GetNumThreads(), 3)
- thread = process.GetThreadAtIndex(2)
- self.assertTrue(thread, "Invalid thread.")
- self.assertEqual(thread.GetName(), "StackCoreScriptedThread.thread-2")
-
- self.assertTrue(target.triple, "Invalid target triple")
- arch = target.triple.split('-')[0]
- supported_arch = ['x86_64', 'arm64', 'arm64e']
- self.assertIn(arch, supported_arch)
- # When creating a corefile of a arm process, lldb saves the exception
- # that triggers the breakpoint in the LC_NOTES of the corefile, so they
- # can be reloaded with the corefile on the next debug session.
- if arch in 'arm64e':
- self.assertTrue(thread.GetStopReason(), lldb.eStopReasonException)
- # However, it's architecture specific, and corefiles made from intel
- # process don't save any metadata to retrieve to stop reason.
- # To mitigate this, the StackCoreScriptedProcess will report a
- # eStopReasonSignal with a SIGTRAP, mimicking what debugserver does.
- else:
- self.assertTrue(thread.GetStopReason(), lldb.eStopReasonSignal)
-
- self.assertEqual(thread.GetNumFrames(), 6)
- frame = thread.GetSelectedFrame()
- self.assertTrue(frame, "Invalid frame.")
- self.assertIn("bar", frame.GetFunctionName())
- self.assertEqual(int(frame.FindValue("i", lldb.eValueTypeVariableArgument).GetValue()), 42)
- self.assertEqual(int(frame.FindValue("j", lldb.eValueTypeVariableLocal).GetValue()), 42 * 42)
diff --git a/lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py b/lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py
new file mode 100644
index 000000000000..61b0c4fd16b1
--- /dev/null
+++ b/lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py
@@ -0,0 +1,110 @@
+"""
+Test python scripted process in lldb
+"""
+
+import os, json, tempfile
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbtest
+
+class StackCoreScriptedProcesTestCase(TestBase):
+
+ NO_DEBUG_INFO_TESTCASE = True
+
+ mydir = TestBase.compute_mydir(__file__)
+
+ def setUp(self):
+ TestBase.setUp(self)
+
+ def tearDown(self):
+ TestBase.tearDown(self)
+
+ def create_stack_skinny_corefile(self, file):
+ self.build()
+ target, process, thread, _ = lldbutil.run_to_source_breakpoint(self, "// break here",
+ lldb.SBFileSpec("main.cpp"))
+ self.assertTrue(process.IsValid(), "Process is invalid.")
+ # FIXME: Use SBAPI to save the process corefile.
+ self.runCmd("process save-core -s stack " + file)
+ self.assertTrue(os.path.exists(file), "No stack-only corefile found.")
+ self.assertTrue(self.dbg.DeleteTarget(target), "Couldn't delete target")
+
+ @skipUnlessDarwin
+ @skipIfOutOfTreeDebugserver
+ def test_launch_scripted_process_stack_frames(self):
+ """Test that we can launch an lldb scripted process from the command
+ line, check its process ID and read string from memory."""
+ self.build()
+ target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
+ self.assertTrue(target, VALID_TARGET)
+
+ for module in target.modules:
+ if 'a.out' in module.GetFileSpec().GetFilename():
+ main_module = module
+ break
+
+ self.assertTrue(main_module, "Invalid main module.")
+ error = target.SetModuleLoadAddress(main_module, 0)
+ self.assertTrue(error.Success(), "Reloading main module at offset 0 failed.")
+
+ os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH'] = '1'
+ def cleanup():
+ del os.environ["SKIP_SCRIPTED_PROCESS_LAUNCH"]
+ self.addTearDownHook(cleanup)
+
+ scripted_process_example_relpath = 'stack_core_scripted_process.py'
+ self.runCmd("command script import " + os.path.join(self.getSourceDir(),
+ scripted_process_example_relpath))
+
+ corefile_process = None
+ with tempfile.NamedTemporaryFile() as file:
+ self.create_stack_skinny_corefile(file.name)
+ corefile_target = self.dbg.CreateTarget(None)
+ corefile_process = corefile_target.LoadCore(self.getBuildArtifact(file.name))
+ self.assertTrue(corefile_process, PROCESS_IS_VALID)
+
+ structured_data = lldb.SBStructuredData()
+ structured_data.SetFromJSON(json.dumps({
+ "backing_target_idx" : self.dbg.GetIndexOfTarget(corefile_process.GetTarget())
+ }))
+ launch_info = lldb.SBLaunchInfo(None)
+ launch_info.SetProcessPluginName("ScriptedProcess")
+ launch_info.SetScriptedProcessClassName("stack_core_scripted_process.StackCoreScriptedProcess")
+ launch_info.SetScriptedProcessDictionary(structured_data)
+
+ error = lldb.SBError()
+ process = target.Launch(launch_info, error)
+ self.assertTrue(error.Success(), error.GetCString())
+ self.assertTrue(process, PROCESS_IS_VALID)
+ self.assertEqual(process.GetProcessID(), 42)
+
+ self.assertEqual(process.GetNumThreads(), 3)
+ thread = process.GetSelectedThread()
+ self.assertTrue(thread, "Invalid thread.")
+ self.assertEqual(thread.GetName(), "StackCoreScriptedThread.thread-2")
+
+ self.assertTrue(target.triple, "Invalid target triple")
+ arch = target.triple.split('-')[0]
+ supported_arch = ['x86_64', 'arm64', 'arm64e']
+ self.assertIn(arch, supported_arch)
+ # When creating a corefile of a arm process, lldb saves the exception
+ # that triggers the breakpoint in the LC_NOTES of the corefile, so they
+ # can be reloaded with the corefile on the next debug session.
+ if arch in 'arm64e':
+ self.assertTrue(thread.GetStopReason(), lldb.eStopReasonException)
+ # However, it's architecture specific, and corefiles made from intel
+ # process don't save any metadata to retrieve to stop reason.
+ # To mitigate this, the StackCoreScriptedProcess will report a
+ # eStopReasonSignal with a SIGTRAP, mimicking what debugserver does.
+ else:
+ self.assertTrue(thread.GetStopReason(), lldb.eStopReasonSignal)
+
+ self.assertEqual(thread.GetNumFrames(), 6)
+ frame = thread.GetSelectedFrame()
+ self.assertTrue(frame, "Invalid frame.")
+ self.assertIn("bar", frame.GetFunctionName())
+ self.assertEqual(int(frame.FindValue("i", lldb.eValueTypeVariableArgument).GetValue()), 42)
+ self.assertEqual(int(frame.FindValue("j", lldb.eValueTypeVariableLocal).GetValue()), 42 * 42)
More information about the lldb-commits
mailing list