[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

I am fine with this. Only suggestion is to use ConstString still for the m_instance_name since we might compare against this name if we are looking for one with a matching name (instead of std::string).



================
Comment at: lldb/include/lldb/Target/Platform.h:889
   bool m_system_arch_set_while_connected;
+  const std::string m_instance_name;
   ConstString
----------------
Do we want to make this a ConstString so finding matching instances is quick and just a pointer compare?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119146/new/

https://reviews.llvm.org/D119146