[Lldb-commits] [lldb] 9e69959 - [lldb] Adjust windows xfails for D119167

[Pavel Labath via lldb-commits]

Author: Pavel Labath
Date: 2022-02-09T12:04:13+01:00
New Revision: 9e6995957ac2df6978d7ff1b9ae97d937d6ac85a

URL: https://github.com/llvm/llvm-project/commit/9e6995957ac2df6978d7ff1b9ae97d937d6ac85a
DIFF: https://github.com/llvm/llvm-project/commit/9e6995957ac2df6978d7ff1b9ae97d937d6ac85a.diff

LOG: [lldb] Adjust windows xfails for D119167

A couple of additional tests pass with that patch. One new test fails
(because it's not testing a slightly different thing). I'll update it
later to restore the original meaning (I don't want to revert as the net
effect is still very positive), but for now this gets the bot green.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
    lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
    lldb/test/API/tools/lldb-server/TestLldbGdbServer.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
index fcab1ea0e49a9..fafaf953be522 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
@@ -125,11 +125,6 @@ def test_QListThreadsInStopReply_supported(self):
         context = self.expect_gdbremote_sequence()
         self.assertIsNotNone(context)
 
-    # In current implementation of llgs on Windows, as a response to '\x03' packet, the debugger
-    # of the native process will trigger a call to DebugBreakProcess that will create a new thread
-    # to handle the exception debug event. So one more stop thread will be notified to the
-    # delegate, e.g. llgs.  So tests below to assert the stop threads number will all fail.
-    @expectedFailureAll(oslist=["windows"])
     @skipIfNetBSD
     def test_stop_reply_reports_multiple_threads(self):
         self.build()
@@ -141,7 +136,6 @@ def test_stop_reply_reports_multiple_threads(self):
         stop_reply_threads = self.gather_stop_reply_threads(5)
         self.assertEqual(len(stop_reply_threads), 5)
 
-    @expectedFailureAll(oslist=["windows"])
     @skipIfNetBSD
     def test_no_QListThreadsInStopReply_supplies_no_threads(self):
         self.build()
@@ -151,7 +145,6 @@ def test_no_QListThreadsInStopReply_supplies_no_threads(self):
         stop_reply_threads = self.gather_stop_reply_threads(5)
         self.assertEqual(len(stop_reply_threads), 0)
 
-    @expectedFailureAll(oslist=["windows"])
     @skipIfNetBSD
     def test_stop_reply_reports_correct_threads(self):
         self.build()
@@ -178,7 +171,6 @@ def test_stop_reply_reports_correct_threads(self):
         for tid in threads:
             self.assertIn(tid, stop_reply_threads)
 
-    @expectedFailureAll(oslist=["windows"])
     @skipIfNetBSD
     def test_stop_reply_contains_thread_pcs(self):
         self.build()

diff  --git a/lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py b/lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
index 92e0596731da8..e03756f240d09 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
@@ -78,6 +78,7 @@ def test_qThreadStopInfo_works_for_multiple_threads(self):
 
     @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48418")
     @expectedFailureNetBSD
+    @expectedFailureAll(oslist=["windows"])
     def test_qThreadStopInfo_only_reports_one_thread_stop_reason_during_interrupt(self):
         self.build()
         self.set_inferior_startup_launch()

diff  --git a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
index 4f19bac7441fa..c6ff42a9a522f 100644
--- a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
+++ b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
@@ -379,7 +379,6 @@ def Hg_switches_to_3_threads(self, pass_pid=False):
             self.assertIsNotNone(context.get("thread_id"))
             self.assertEqual(int(context.get("thread_id"), 16), thread)
 
-    @expectedFailureAll(oslist=["windows"]) # expect 4 threads
     @skipIf(compiler="clang", compiler_version=['<', '11.0'])
     def test_Hg_switches_to_3_threads_launch(self):
         self.build()
@@ -402,21 +401,18 @@ def Hg_fails_on_pid(self, pass_pid):
 
         self.expect_gdbremote_sequence()
 
-    @expectedFailureAll(oslist=["windows"])
     @add_test_categories(["llgs"])
     def test_Hg_fails_on_another_pid(self):
         self.build()
         self.set_inferior_startup_launch()
         self.Hg_fails_on_pid(1)
 
-    @expectedFailureAll(oslist=["windows"])
     @add_test_categories(["llgs"])
     def test_Hg_fails_on_zero_pid(self):
         self.build()
         self.set_inferior_startup_launch()
         self.Hg_fails_on_pid(0)
 
-    @expectedFailureAll(oslist=["windows"])
     @add_test_categories(["llgs"])
     def test_Hg_fails_on_minus_one_pid(self):
         self.build()