[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 8 10:21:15 PST 2022


mib added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:529
+            if key == "x":
+                registers.update(self.parse_thread_registers({ str(idx) : reg
+                                                              for idx,reg in
----------------
shafik wrote:
> nitpick: Is there a better way to format this code or rewrite it so that is reads better?
@shafik I didn't feel like creating a variable on top of that but if you think it can improve readability, I can do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119168/new/

https://reviews.llvm.org/D119168



More information about the lldb-commits mailing list