[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 8 03:59:57 PST 2022


labath updated this revision to Diff 406761.
labath marked 2 inline comments as done.
labath added a comment.

Use a trap opcode instead of a signal. This has two main drawbacks:

- needs some architecture-specific code (gcc does not have __builtin_debugtrap)
- if we ever need to resume from this state, we will need to add special handling to make progress on systems where the trap opcode does not increment the PC

I still think it beats sleeps, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119167/new/

https://reviews.llvm.org/D119167

Files:
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
  lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py
  lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
  lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
  lldb/test/API/tools/lldb-server/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119167.406761.patch
Type: text/x-patch
Size: 16699 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220208/30244640/attachment-0001.bin>


More information about the lldb-commits mailing list