[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

Tue Feb 8 02:03:41 PST 2022

DavidSpickett added a comment.

I'm pretty sure I've seen this sort of failure before but can't remember if it was locally or on one of many bots. (which probably means all of them!) This seems like a good improvement.

================
Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py:699
+        threads = self.parse_threadinfo_packets(context)
+        self.assertGreaterEqual(len(threads), thread_count)
+        return context, threads
----------------
I don't think this is an issue but what would cause you to have > the number of threads?

Are there automatically created threads sometimes that we don't explicitly ask for.

================
Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py:22
+        key_vals_text = context.get("stop_reply_kv")
+        self.assertIsNotNone(key_vals_text)

----------------
If there's a very slim chance this text is `""` you could `assertTrue` and catch both situations.

================
Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py:34
         kv_dict = self.parse_key_val_dict(key_vals_text)
         self.assertIsNotNone(kv_dict)

----------------
Afaict `parse_key_val_dict` will never return None. At worst an empty dictionary.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119167/new/

https://reviews.llvm.org/D119167