[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

Mon Feb 7 07:02:55 PST 2022

labath added a comment.

In D118794#3290552 <https://reviews.llvm.org/D118794#3290552>, @DavidSpickett wrote:

> Also if anyone does know how or if debugserver handles this situation, that would be good to know.

I don't know about debugserver, but it would definitely be interesting to check what gdb(server) does here. If it's doing this clientside, then sooner or later somebody will come along wanting to add gdbserver compatibility, and we'll end up doing it in both places.

One side-effect of doing it server-side is that this would interfere with our memory caching code, and we could end up re-reading the same piece of memory (with different tags) multiple times. May not make a big difference in practice, but I think it's a sign that this is done at the wrong level.

Doing this at the level of Target/Process::ReadMemory should still be fairly centralized, and it would not interfere with caching.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118794/new/

https://reviews.llvm.org/D118794