[Lldb-commits] [lldb] 4a85493 - [lldb] Guard libstdc++ specific 'frame var' test

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Sun Jan 9 21:37:49 PST 2022


Author: Dave Lee
Date: 2022-01-09T21:37:42-08:00
New Revision: 4a8549354c1b77ce830e488ceefa05dfb4bc9325

URL: https://github.com/llvm/llvm-project/commit/4a8549354c1b77ce830e488ceefa05dfb4bc9325
DIFF: https://github.com/llvm/llvm-project/commit/4a8549354c1b77ce830e488ceefa05dfb4bc9325.diff

LOG: [lldb] Guard libstdc++ specific 'frame var' test

While working on D116788 (properly error out of `frame var`), this libstdc++
specific `frame var` invocation was found in the tests. This test is in the
generic directory, but has this one case that requires libstdc++. The fix here
is to put the one `expect()` inside of a condition that checks for libstdc++.

Differential Revision: https://reviews.llvm.org/D116901

Added: 
    

Modified: 
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py
index 82fe84efc7b45..74269ef55e824 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py
@@ -62,12 +62,14 @@ def cleanup():
         self.expect("frame variable numbers_list --raw", matching=False,
                     substrs=['size=0',
                              '{}'])
-        self.expect(
-            "frame variable &numbers_list._M_impl._M_node --raw",
-            matching=False,
-            substrs=[
-                'size=0',
-                '{}'])
+
+        if stdlib_type == USE_LIBSTDCPP:
+            self.expect(
+                "frame variable &numbers_list._M_impl._M_node --raw",
+                matching=False,
+                substrs=[
+                    'size=0',
+                    '{}'])
 
         self.expect("frame variable numbers_list",
                     substrs=['size=0',


        


More information about the lldb-commits mailing list