[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

[Chris Bieneman via Phabricator via lldb-commits]

beanz added a comment.

`LLVM_LIBRARY_DIR` and `LLVM_LIBRARY_DIRS` aren’t intended to serve the same purpose. The `S` in `DIRS` is intentional to convey that it is a list of directories, not necessarily a single value, and it would definitely break many uses of `LLVM_LIBRARY_DIR` if it was a list. There are several (not correctly handled) build configurations where `LLVM_SHLIB_OUTPUT_INTDIR` and the shared library install directory are not the same as the static archive install directory. In those cases we _should_ be setting `LLVM_LIBRARY_DIRS` to be an array containing both `LLVM_LIBRARY_DIR` and `LLVM_TOOLS_BINARY_DIR`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116467/new/

https://reviews.llvm.org/D116467