[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

Wed Dec 22 11:35:21 PST 2021

ljmf00 added a comment.

In D116136#3206294 <https://reviews.llvm.org/D116136#3206294>, @labath wrote:

> I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ `char8_t` map to this type?

Yes, that is right, but I'm doing it on the stacked patch D116138 <https://reviews.llvm.org/D116138>. Perhaps I should squash both? I just tried to separate the changes.

================
Comment at: lldb/include/lldb/lldb-enumerations.h:750
   eBasicTypeUnsignedWChar,
+  eBasicTypeChar8,
   eBasicTypeChar16,
----------------
labath wrote:
> ljmf00 wrote:
> > Does the order of the enum matter here? Since this is part of the public API it might break something externally.
> Yes, this should go the the end of the enum (though we're not very good at enforcing it, so I wouldn't be surprised if some of these values were added "in the middle").
Ok, I'm going to move to the end to avoid user breakage.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116136/new/

https://reviews.llvm.org/D116136