[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

Wed Dec 22 03:35:45 PST 2021

labath added a comment.

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ `char8_t` map to this type?

================
Comment at: lldb/include/lldb/lldb-enumerations.h:750
   eBasicTypeUnsignedWChar,
+  eBasicTypeChar8,
   eBasicTypeChar16,
----------------
ljmf00 wrote:
> Does the order of the enum matter here? Since this is part of the public API it might break something externally.
Yes, this should go the the end of the enum (though we're not very good at enforcing it, so I wouldn't be surprised if some of these values were added "in the middle").

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116136/new/

https://reviews.llvm.org/D116136