[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

[Levon Ter-Grigoryan via Phabricator via lldb-commits]

PatriosTheGreat added a comment.

Hi Pavel.

Got it,
Thanks for fixing and clarification.

In D114554#3152953 <https://reviews.llvm.org/D114554#3152953>, @labath wrote:

> I've fixed this in rGc0e3bb4d4ba306 <https://reviews.llvm.org/rGc0e3bb4d4ba3064c42fb8e1ee9f001235d9af04c>.
>
>> Not sure if it's better to revert original commit (https://reviews.llvm.org/rGf23b829a2635a6d833bdc81a12d6217b52ae9e45) and then re-commit the change with this fix.
>
> For a simple fix like this, it doesn't really matter what you do. Just don't leave the build broken for extended periods of time. :)
>
> That said, it's pretty hard to do anything when you don't have commit access to the repository, so part of the responsibility also lies with the person who commits the patch for you. I think that, for a while, we had the problem that the blame emails were not going to the person who committed the patch (only the author), but I was under the impression that was now fixed. David, did you get any breakage emails about that commit ?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114554/new/

https://reviews.llvm.org/D114554