[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

[Levon Ter-Grigoryan via Phabricator via lldb-commits]

PatriosTheGreat created this revision.
PatriosTheGreat added reviewers: DavidSpickett, JDevlieghere, shafik.
PatriosTheGreat requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

My recent change (https://reviews.llvm.org/D104413)  broke the lldb tests (https://lab.llvm.org/buildbot#builders/17/builds/13800).
The problem is that skipIfReproducer annotation  was removed in this change: https://github.com/llvm/llvm-project/commit/b505ed9d313653782b81bbc97979c98edb205558

In this change I remove unnecessary annotation. I checked tests on my local Linux machine they are passing on it.
Not sure if it's better to revert original commit (https://reviews.llvm.org/rGf23b829a2635a6d833bdc81a12d6217b52ae9e45) and then re-commit the change with this fix.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114554

Files:
  lldb/test/API/python_api/file_handle/TestFileHandle.py


Index: lldb/test/API/python_api/file_handle/TestFileHandle.py
===================================================================
--- lldb/test/API/python_api/file_handle/TestFileHandle.py
+++ lldb/test/API/python_api/file_handle/TestFileHandle.py
@@ -853,7 +853,6 @@
         with open(self.out_filename, 'r') as f:
             self.assertEqual(f.read().strip(), "Frobozz")
 
-    @skipIfReproducer # lldb::FileSP used in typemap cannot be instrumented.
     def test_set_sbstream(self):
         with open(self.out_filename, 'w') as outf:
             outsbf = lldb.SBFile(outf.fileno(), "w", False)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114554.389571.patch
Type: text/x-patch
Size: 603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211124/60978d62/attachment.bin>