[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 5 13:11:20 PDT 2021


mgorny accepted this revision.
mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1113
+    std::string packet =
+        "QEnableCompression:type:" + std::string(avail_name) + ";";
+    if (SendPacketAndWaitForResponse(packet, response) != PacketResult::Success)
----------------
I'd personally prefer `avail_name.str()` instead of explicit `std::string()` but that's just me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113314/new/

https://reviews.llvm.org/D113314



More information about the lldb-commits mailing list