[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

[Med Ismail Bennani via Phabricator via lldb-commits]

mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.

LGTM besides some minor things. Thanks for fixing this @jingham !



================
Comment at: lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py:85
+        #self.dbg.HandleCommand("log enable lldb process")
+        #self.dbg.HandleCommand("log enable gdb-remote packets process")
+
----------------
Did you forget to remove these comments or did you leave them on purpose  ?


================
Comment at: lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py:89
+        self.assertTrue(error.Success(), "Launch failed: {0}".format(error.description))
+        # If we are synchronous, we have to wait for the events:
+        if not synchronous:
----------------
This comment doesn't match the following condition


================
Comment at: lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py:134
+        #FIXME: This should be a cleanup
+        self.dbg.SetAsync(old_async)
+
----------------
As you mentioned in the FIXME above, this should be a cleanup (similarly to what `TestPlatformSDK.py` does)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112747/new/

https://reviews.llvm.org/D112747