[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

[Jim Ingham via Phabricator via lldb-commits]

jingham created this revision.
jingham added reviewers: clayborg, JDevlieghere, mib.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

We found a bug introduced by changes for the ScriptedProcess.  It only manifests itself is you run a process with stop-at-entry set to true and when you are using an async debugger and when you are using a remote process.  The solution is trivial.  The majority of the patch is a test for stop-at-entry in the four cases of "sync & async" debugger crossed with "remote or local" process.  The test both tests that stop-at-entry really does stop at entry, and then tests that we can resume afterwards.

I wrote the test for darwin because I don't know how to assert that we successfully stopped at entry on Linux or Windows.  If someone more familiar with those platforms wants to extend the test to either of those hosts, it should be straightforward.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112747

Files:
  lldb/source/Target/Process.cpp
  lldb/test/API/functionalities/launch_stop_at_entry/Makefile
  lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py
  lldb/test/API/functionalities/launch_stop_at_entry/main.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112747.383116.patch
Type: text/x-patch
Size: 7919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211028/17c98d4b/attachment-0001.bin>