[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

Wed Oct 27 09:43:11 PDT 2021

mgorny added a comment.

In D111890#3090632 <https://reviews.llvm.org/D111890#3090632>, @thakis wrote:

> This causes lots of warnings on Windows, where TERMIOS is false: http://45.33.8.238/win/47744/step_4.txt (look for "Terminal.cpp"). Could you take a look? It looks like return statements are genuinely missing there.

When `LLDB_ENABLE_TERMIOS` is false, `GetData()` always returns an error, so the code below should not be reachable. I suppose I could add `llvm_unreachable()` for that. I'll try that and make a diff if it works.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111890/new/

https://reviews.llvm.org/D111890