[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

Nico Weber via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 27 09:28:51 PDT 2021


thakis added a comment.
Herald added a subscriber: JDevlieghere.

This causes lots of warnings on Windows, where TERMIOS is false: http://45.33.8.238/win/47744/step_4.txt (look for "Terminal.cpp"). Could you take a look? It looks like return statements are genuinely missing there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111890/new/

https://reviews.llvm.org/D111890



More information about the lldb-commits mailing list