[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

Mon Oct 25 10:16:22 PDT 2021

Not actually sure when/how Green Dragon is mailing external people,
but usually someone just watches the build bot and emails/comments on
commits that are breaking the buildbot. Green Dragon is more of a
monte carlo simulation than a real build bot so I wouldn't be
surprised if it doesn't send automatic failure emails to non-Apple
people.

Also that 'let's write a test' was more a note for myself to write
that test (which I hopefully get around today).

Am Mo., 25. Okt. 2021 um 19:10 Uhr schrieb David Blaikie via
Phabricator <reviews at reviews.llvm.org>:
>
> dblaikie added a comment.
>
> In D112340#3081540 <https://reviews.llvm.org/D112340#3081540>, @teemperor wrote:
>
> > In D112340#3081532 <https://reviews.llvm.org/D112340#3081532>, @dblaikie wrote:
> >
> >> Sorry I missed this - are these tested anywhere/should I have been able to discover if these needed to be changed before I made the change?
> >
> > TestCompactVectors tests this but its unfortunately marked as Darwin-only (as it includes the `Accelerate` framework). Providing a platform-neutral test that just typedef's the same things as Accelerate (in addition to the test including the real framework) seems like a good idea.
>
> Good to know - will keep it in mind, but don't think I'm up for writing that test right now myself (not especially familiar with lldb test infrastructure, etc).
>
> Was this reported by a buildbot, do you think/know of? Probably would've been happy to debug-via-buildbot and fix it that way, but don't recall seeing a fail-mail about this (but as always, there's a fair bit of buildbot noise and sometimes it's hard to find the cause/issue in a fail-mail such that I end up ignoring them)
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D112340/new/
>
> https://reviews.llvm.org/D112340
>