[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

[David Blaikie via Phabricator via lldb-commits]

dblaikie added a comment.

In D112340#3081540 <https://reviews.llvm.org/D112340#3081540>, @teemperor wrote:

> In D112340#3081532 <https://reviews.llvm.org/D112340#3081532>, @dblaikie wrote:
>
>> Sorry I missed this - are these tested anywhere/should I have been able to discover if these needed to be changed before I made the change?
>
> TestCompactVectors tests this but its unfortunately marked as Darwin-only (as it includes the `Accelerate` framework). Providing a platform-neutral test that just typedef's the same things as Accelerate (in addition to the test including the real framework) seems like a good idea.

Good to know - will keep it in mind, but don't think I'm up for writing that test right now myself (not especially familiar with lldb test infrastructure, etc).

Was this reported by a buildbot, do you think/know of? Probably would've been happy to debug-via-buildbot and fix it that way, but don't recall seeing a fail-mail about this (but as always, there's a fair bit of buildbot noise and sometimes it's hard to find the cause/issue in a fail-mail such that I end up ignoring them)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112340/new/

https://reviews.llvm.org/D112340