[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

Tue Oct 19 00:09:38 PDT 2021

mgorny added a comment.

In D111964#3072088 <https://reviews.llvm.org/D111964#3072088>, @labath wrote:

> I think we could introduce something like `Connection::IsReliable` and key that behavior off of that.
>
> Although I can't say I actually understand how the "ack" mode is supposed to work. It seems like it would be very hard to recover from transmission errors that affect the `$` or `#` parts of the packet.

FWICS, gdb uses "noack" mode unconditionally. I somewhat suspect that the "ack" mode might just be a historical thing that doesn't actually serve any purpose.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111964/new/

https://reviews.llvm.org/D111964