[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

Tue Oct 19 00:03:32 PDT 2021

labath added a comment.

In D111964#3071292 <https://reviews.llvm.org/D111964#3071292>, @mgorny wrote:

>>> This is not fully functional yet, as lldb-server
>>> crashes when attempting to send long packets (e.g. target.xml contents).
>>
>> I am guessing you'll also want to disable QStartNoAckMode for these connections (?)
>
> I suppose this makes sense. Are you suggesting special-casing `serial://` or do you have something else in mind?

I think we could introduce something like `Connection::IsReliable` and key that behavior off of that.

Although I can't say I actually understand how the "ack" mode is supposed to work. It seems like it would be very hard to recover from transmission errors that affect the `$` or `#` parts of the packet.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111964/new/

https://reviews.llvm.org/D111964