[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/include/lldb/Host/Terminal.h:21
 public:
+  struct Data;
+
----------------
Move this into the protected section


================
Comment at: lldb/source/Host/common/Terminal.cpp:76
+  struct termios &fd_termios = data->m_termios;
+  bool set_corectly = false;
+  if (enabled) {
----------------
mgorny wrote:
> My gut feeling is telling me that this can be simplified somehow… or we could assume `tcsetattr()` is cheap and just do the change unconditionally.
yeah, I think it'd be fine to call tcsetattr unconditionally


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111890/new/

https://reviews.llvm.org/D111890