[Lldb-commits] [PATCH] D111920: Test untested variants of BreakpointCreateBySourceRegex

[Jim Ingham via Phabricator via lldb-commits]

jingham created this revision.
jingham added reviewers: aprantl, JDevlieghere.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Add tests for the other variants of BreakpointCreateBySourceRegex.

      

I added some tests for the case where the breakpoints take immediately
to the extant test case, and made a new test case for when the source
regex breakpoint will be set in a dlopen-ed library.

      

I also noticed when doing this that "lldbutil.run_to_source_breakpoint
can't handle the case where the breakpoint will be in a dlopen-ed
library, since it requires the breakpoint to have at least 1 location
before run.  I fixed that by adding a parameter to say whether a
before run location is expected.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111920

Files:
  lldb/packages/Python/lldbsuite/test/lldbutil.py
  lldb/test/API/functionalities/breakpoint/break_in_loaded_dylib/Makefile
  lldb/test/API/functionalities/breakpoint/break_in_loaded_dylib/TestBreakInLoadedDylib.py
  lldb/test/API/functionalities/breakpoint/break_in_loaded_dylib/b.cpp
  lldb/test/API/functionalities/breakpoint/break_in_loaded_dylib/main.cpp
  lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommandsFromPython.py
  lldb/test/API/functionalities/breakpoint/breakpoint_command/bktptcmd.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111920.380133.patch
Type: text/x-patch
Size: 9876 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211016/7b7163dd/attachment.bin>