[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Actually, they aren't testing the same "sort" of thing, it's exactly the same test: "was the breakpoint hit once".  But those tests are also really inaccurate as they just ask whether any breakpoint has a hit count of 1.  It would be really easy to edit a test,  add another breakpoint that gets hit before you get to this self.expect.  In that case, this test would stop testing what it was intended to test.

I know you didn't add these expects, but if you have the time it would be great to add lldbutils.GetBreakpointCount(breakpoint_no) and then actually pass the right breakpoint to the test...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111899/new/

https://reviews.llvm.org/D111899