[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Ok, take a look now. I added a GlobalStats class that contains the "enable/disable" state of the statistics gathering. This shows how things can be organized and dumped.

A few things about the current approach: Stats classes in Statistics.h are designed to be able to be fetched, like TargetStats, and then any class that owns a collection of these, like how GlobalStats could own a std::vector<TargetStats> could then aggregate any sub stats into key/value pairs at this higher level. The original patch will end up gathering ModuleStats for each module in TargetStats, and then collecting total stats for debug info size, debug info parse and index time, symbol table parse and index time, and these total stats can be aggregated and displayed. So hopefully this shows the direction I was thinking. Let me know what you think and what changes you would like to see here.

-


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111686/new/

https://reviews.llvm.org/D111686