[Lldb-commits] [PATCH] D111816: [lldb] Remove logging from Platform::~Platform

Thu Oct 14 12:37:23 PDT 2021

teemperor added a comment.

Fixed, thanks!

In D111816#3064923 <https://reviews.llvm.org/D111816#3064923>, @thakis wrote:

> http://45.33.8.238/mac/37050/step_4.txt
>
>   In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:9:
>   In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.h:12:
>   In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/map:495:
>   In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__node_handle:63:
>   In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/memory:682:
>   In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/shared_ptr.h:25:
>   ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:50:19: error: invalid application of 'sizeof' to an incomplete type 'lldb_private::ModuleCache'
>       static_assert(sizeof(_Tp) > 0,
>                     ^~~~~~~~~~~
>   ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:315:7: note: in instantiation of member function 'std::default_delete<lldb_private::ModuleCache>::operator()' requested here
>         __ptr_.second()(__tmp);
>         ^
>   ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:269:19: note: in instantiation of member function 'std::unique_ptr<lldb_private::ModuleCache>::reset' requested here
>     ~unique_ptr() { reset(); }
>                     ^
>   ../../lldb/include/lldb/Target/Platform.h:78:3: note: in instantiation of member function 'std::unique_ptr<lldb_private::ModuleCache>::~unique_ptr' requested here
>     ~Platform() override = default;
>     ^
>   ../../lldb/include/lldb/Target/Platform.h:39:7: note: forward declaration of 'lldb_private::ModuleCache'
>   class ModuleCache;
>         ^

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111816/new/

https://reviews.llvm.org/D111816