[Lldb-commits] [lldb] 482c53f - [lldb] Move ~Platform to source file

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 14 12:37:07 PDT 2021


Author: Raphael Isemann
Date: 2021-10-14T21:36:46+02:00
New Revision: 482c53fa0dce16c0edebb494117dcc8dd383427e

URL: https://github.com/llvm/llvm-project/commit/482c53fa0dce16c0edebb494117dcc8dd383427e
DIFF: https://github.com/llvm/llvm-project/commit/482c53fa0dce16c0edebb494117dcc8dd383427e.diff

LOG: [lldb] Move ~Platform to source file

The called destructors of the members require the includes that are only
in the source file.

Added: 
    

Modified: 
    lldb/include/lldb/Target/Platform.h
    lldb/source/Target/Platform.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Target/Platform.h b/lldb/include/lldb/Target/Platform.h
index 81858bbfa702..7cb534afe6ec 100644
--- a/lldb/include/lldb/Target/Platform.h
+++ b/lldb/include/lldb/Target/Platform.h
@@ -75,7 +75,7 @@ class Platform : public PluginInterface {
 
   /// The destructor is virtual since this class is designed to be inherited
   /// from by the plug-in instance.
-  ~Platform() override = default;
+  ~Platform() override;
 
   static void Initialize();
 

diff  --git a/lldb/source/Target/Platform.cpp b/lldb/source/Target/Platform.cpp
index a414bc746083..07cbc119740a 100644
--- a/lldb/source/Target/Platform.cpp
+++ b/lldb/source/Target/Platform.cpp
@@ -395,6 +395,8 @@ Platform::Platform(bool is_host)
   LLDB_LOGF(log, "%p Platform::Platform()", static_cast<void *>(this));
 }
 
+Platform::~Platform() = default;
+
 void Platform::GetStatus(Stream &strm) {
   std::string s;
   strm.Printf("  Platform: %s\n", GetPluginName().GetCString());


        


More information about the lldb-commits mailing list