[Lldb-commits] [lldb] 5891705 - [lldb] Skip several lldb tests that are flaky on Windows

[Stella Stamenova via lldb-commits]

Author: Stella Stamenova
Date: 2021-10-13T09:46:41-07:00
New Revision: 58917054c29878ff3462f73b32a3e5dfa64d83f9

URL: https://github.com/llvm/llvm-project/commit/58917054c29878ff3462f73b32a3e5dfa64d83f9
DIFF: https://github.com/llvm/llvm-project/commit/58917054c29878ff3462f73b32a3e5dfa64d83f9.diff

LOG: [lldb] Skip several lldb tests that are flaky on Windows

These tests fail every 10 or so runs on Windows causing both local failures as well as buildbot failures.

Differential Revision: https://reviews.llvm.org/D111659

Added: 
    

Modified: 
    lldb/test/API/commands/process/attach/TestProcessAttach.py
    lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
    lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
    lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/process/attach/TestProcessAttach.py b/lldb/test/API/commands/process/attach/TestProcessAttach.py
index 265e9e1a5687d..b2d6878b13c0f 100644
--- a/lldb/test/API/commands/process/attach/TestProcessAttach.py
+++ b/lldb/test/API/commands/process/attach/TestProcessAttach.py
@@ -101,6 +101,7 @@ def test_attach_to_process_by_name(self):
         process = target.GetProcess()
         self.assertTrue(process, PROCESS_IS_VALID)
 
+    @skipIfWindows # This test is flaky on Windows
     @expectedFailureNetBSD
     def test_attach_to_process_by_id_correct_executable_offset(self):
         """

diff  --git a/lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py b/lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
index 9993768df06f3..2bc9a05c5e1b9 100644
--- a/lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
+++ b/lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
@@ -16,6 +16,7 @@ class TestAutoInstallMainExecutable(TestBase):
     NO_DEBUG_INFO_TESTCASE = True
 
     @skipIfRemote
+    @skipIfWindows # This test is flaky on Windows
     def test_target_auto_install_main_executable(self):
         if lldbgdbserverutils.get_lldb_server_exe() is None:
           self.skipTest("lldb-server not found")

diff  --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
index dd71e5077d47c..ded3ff6f849b6 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
@@ -13,6 +13,7 @@ class TestGdbRemoteAttachOrWait(gdbremote_testcase.GdbRemoteTestCaseBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
+    @skipIfWindows # This test is flaky on Windows
     def test_launch_before_attach_with_vAttachOrWait(self):
         exe = '%s_%d' % (self.testMethodName, os.getpid())
         self.build(dictionary={'EXE': exe})
@@ -57,6 +58,7 @@ def test_launch_before_attach_with_vAttachOrWait(self):
         reported_pid = int(pid_text, base=16)
         self.assertEqual(reported_pid, inferior.pid)
 
+    @skipIfWindows # This test is flaky on Windows
     def test_launch_after_attach_with_vAttachOrWait(self):
         exe = '%s_%d' % (self.testMethodName, os.getpid())
         self.build(dictionary={'EXE': exe})

diff  --git a/lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py b/lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
index deb82ed5183b1..980bcb9c9d7c0 100644
--- a/lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
+++ b/lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
@@ -13,6 +13,7 @@ class TestGdbRemoteAttachWait(gdbremote_testcase.GdbRemoteTestCaseBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
+    @skipIfWindows # This test is flaky on Windows
     def test_attach_with_vAttachWait(self):
         exe = '%s_%d' % (self.testMethodName, os.getpid())