[Lldb-commits] [PATCH] D111634: [lldb] Print embedded nuls in char arrays (PR44649)

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:40
+    //% self.expect_var_path("c.data", summary=r'"F\0O"')
     //% self.runCmd("setting set escape-non-printables false")
     //% self.expect_var_path('stdstring', summary='"Hello\t\tWorld\nI am here\t\tto say hello\n"')
----------------
I think the whole 'empty lines break inline tests' thing has been fixed at some point, so could you drop a new line between this and the printable thing when you land?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111634/new/

https://reviews.llvm.org/D111634