[Lldb-commits] [PATCH] D110298: Add "command multiword add" and the ability to add script commands into a user multiword hierarchy

[Jim Ingham via Phabricator via lldb-commits]

jingham updated this revision to Diff 379145.
jingham marked an inline comment as done.
jingham added a comment.

I changed the command name from "command multiword" to "command container".

Greg noted that "multiword" is what we used for these but it's actually not a great description of what you are adding.   "Command Containers" seems closer.  It doesn't also reflect the fact that you can nest containers in containers, but I think that's not going to confuse anyone.

That's the best name I could come up with, but I do think it's better than "command multiword".

I also addressed Jonas' comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110298/new/

https://reviews.llvm.org/D110298

Files:
  lldb/include/lldb/Interpreter/CommandCompletions.h
  lldb/include/lldb/Interpreter/CommandInterpreter.h
  lldb/include/lldb/Interpreter/CommandObject.h
  lldb/include/lldb/Interpreter/CommandObjectMultiword.h
  lldb/source/API/SBCommandInterpreter.cpp
  lldb/source/Commands/CommandCompletions.cpp
  lldb/source/Commands/CommandObjectApropos.cpp
  lldb/source/Commands/CommandObjectCommands.cpp
  lldb/source/Commands/CommandObjectHelp.cpp
  lldb/source/Commands/CommandObjectMultiword.cpp
  lldb/source/Commands/Options.td
  lldb/source/Interpreter/CommandInterpreter.cpp
  lldb/source/Interpreter/CommandObject.cpp
  lldb/test/API/commands/command/container/TestContainerCommands.py
  lldb/test/API/commands/command/container/welcome.py
  lldb/test/API/commands/command/invalid-args/TestInvalidArgsCommand.py
  lldb/test/API/commands/command/script/TestCommandScript.py
  lldb/test/API/commands/expression/char/main.cpp
  lldb/test/API/functionalities/completion/TestCompletion.py
  lldb/unittests/Interpreter/CMakeLists.txt
  lldb/unittests/Interpreter/TestCommandPaths.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110298.379145.patch
Type: text/x-patch
Size: 81343 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211012/83d9f6c9/attachment-0001.bin>