[Lldb-commits] [PATCH] D111435: [lldb] [DynamicRegisterInfo] Support setting from vector<Register>

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/unittests/Target/DynamicRegisterInfoTest.cpp:176-178
+    EXPECT_NE(reg, nullptr);
+    if (!reg)
+      return;
----------------
labath wrote:
> ASSERT_NE(reg, nullptr);
Actually, the idea was to test all registers even if one failed; though I suppose since we're now starting with the lowest index, higher indices won't work either.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111435/new/

https://reviews.llvm.org/D111435