[Lldb-commits] [PATCH] D111216: [lldb] [ABI/X86] Split plugin class and base i386 class

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 6 02:51:29 PDT 2021


mgorny added inline comments.


================
Comment at: lldb/source/Plugins/ABI/X86/ABIX86_i386.h:14
+
+class ABIX86_i386 : public lldb_private::MCBasedABI {
+public:
----------------
For the record, I'm not married to this name ;-). I was originally thinking of `ABIX86_32` but it felt weird when all the ABIs carry `_i386` suffix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111216/new/

https://reviews.llvm.org/D111216



More information about the lldb-commits mailing list