[Lldb-commits] [PATCH] D111216: [lldb] [ABI/X86] Split plugin class and base i386 class

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 6 02:50:42 PDT 2021


mgorny created this revision.
mgorny added reviewers: labath, teemperor, krytarowski, emaste.
Herald added a subscriber: pengfei.
mgorny requested review of this revision.

Split the ABIX86 class into two classes: ABIX86 class used to define
the plugin, and ABIX86_i386 class that is the base for 32-bit ABIs.
This makes ABIX86 more suitable to become a common class for all ABIs,
and removes the confusing concept that ABIX86 initializes 64-bit ABIs
but is only the base for 32-bit ABIs.


https://reviews.llvm.org/D111216

Files:
  lldb/source/Plugins/ABI/X86/ABIMacOSX_i386.h
  lldb/source/Plugins/ABI/X86/ABISysV_i386.h
  lldb/source/Plugins/ABI/X86/ABIX86.cpp
  lldb/source/Plugins/ABI/X86/ABIX86.h
  lldb/source/Plugins/ABI/X86/ABIX86_64.h
  lldb/source/Plugins/ABI/X86/ABIX86_i386.cpp
  lldb/source/Plugins/ABI/X86/ABIX86_i386.h
  lldb/source/Plugins/ABI/X86/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111216.377481.patch
Type: text/x-patch
Size: 6646 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211006/8a286f7f/attachment-0001.bin>


More information about the lldb-commits mailing list