[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

[Jaroslav Sevcik via Phabricator via lldb-commits]

jarin updated this revision to Diff 375901.
jarin added a comment.

Changed the test to avoid running the process and use `image lookup` instead of `frame variable`.

I think I would still slightly prefer `frame variable`, mostly because there seem to be differences between what `image lookup` and `frame variable` show (`image lookup` omit variables that have DW_AT_location disjoint from the inspected address). As opposed to `image lookup`, `frame variable` tests more directly what the users would actually use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110571/new/

https://reviews.llvm.org/D110571

Files:
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  lldb/test/API/functionalities/unused-inlined-parameters/Makefile
  lldb/test/API/functionalities/unused-inlined-parameters/TestUnusedInlinedParameters.py
  lldb/test/API/functionalities/unused-inlined-parameters/main.c
  lldb/test/Shell/SymbolFile/DWARF/x86/Inputs/unused-inlined-params.s
  lldb/test/Shell/SymbolFile/DWARF/x86/unused-inlined-params.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110571.375901.patch
Type: text/x-patch
Size: 32900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210929/c1876b31/attachment-0001.bin>