[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

Wed Sep 29 07:50:19 PDT 2021

jarin added a comment.

In D110571#3030222 <https://reviews.llvm.org/D110571#3030222>, @labath wrote:

> In D110571#3030192 <https://reviews.llvm.org/D110571#3030192>, @jarin wrote:
>
>> This still uses `frame variable` rather than `image lookup`, mostly because `frame variable` tests better the user experience and the cognitive overhead for making the code runnable does not seem to be too high.
>
> This is not really about "cognitive overhead", but "who can run this test". With a running process the answer is "a person with a linux x86 machine". With image lookup it's "everyone". It's also easier to debug failures in the test, as less code gets run before you get to the interesting part.

Good point. Would you prefer to recast the test in terms of image lookup and get rid of checking the stack trace?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110571/new/

https://reviews.llvm.org/D110571