[Lldb-commits] [lldb] d727bd6 - [lldb] [test] Skip A/vRun/QEnvironment* tests on Windows, and fix them

[Michał Górny via lldb-commits]

Author: Michał Górny
Date: 2021-09-10T16:34:20+02:00
New Revision: d727bd696293a5e8ba63c01b6ec80b2b17eb373a

URL: https://github.com/llvm/llvm-project/commit/d727bd696293a5e8ba63c01b6ec80b2b17eb373a
DIFF: https://github.com/llvm/llvm-project/commit/d727bd696293a5e8ba63c01b6ec80b2b17eb373a.diff

LOG: [lldb] [test] Skip A/vRun/QEnvironment* tests on Windows, and fix them

Skip A/vRun/QEnvironment* tests on Windows as testing for output is
known not to work there.  Add a missing output check to the vRun test.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-server/TestLldbGdbServer.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
index 9b901756c093..2f76654c47b1 100644
--- a/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
+++ b/lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
@@ -1250,6 +1250,7 @@ def test_P_and_p_thread_suffix_work(self):
             self.assertEqual(read_value, expected_reg_values[thread_index])
             thread_index += 1
 
+    @skipIfWindows # No pty support to test any inferior output
     @add_test_categories(["llgs"])
     def test_launch_via_A(self):
         self.build()
@@ -1274,6 +1275,7 @@ def test_launch_via_A(self):
         self.assertEqual(context["O_content"],
                          b'arg1\r\narg2\r\narg3\r\n')
 
+    @skipIfWindows # No pty support to test any inferior output
     @add_test_categories(["llgs"])
     def test_launch_via_vRun(self):
         self.build()
@@ -1292,6 +1294,8 @@ def test_launch_via_vRun(self):
              "send packet: $W00#00"],
             True)
         context = self.expect_gdbremote_sequence()
+        self.assertEqual(context["O_content"],
+                         b'arg1\r\narg2\r\narg3\r\n')
 
     @add_test_categories(["llgs"])
     def test_launch_via_vRun_no_args(self):
@@ -1311,6 +1315,7 @@ def test_launch_via_vRun_no_args(self):
             True)
         self.expect_gdbremote_sequence()
 
+    @skipIfWindows # No pty support to test any inferior output
     @add_test_categories(["llgs"])
     def test_QEnvironment(self):
         self.build()
@@ -1338,6 +1343,7 @@ def test_QEnvironment(self):
         context = self.expect_gdbremote_sequence()
         self.assertEqual(context["O_content"], b"test\r\na=z\r\n")
 
+    @skipIfWindows # No pty support to test any inferior output
     @add_test_categories(["llgs"])
     def test_QEnvironmentHexEncoded(self):
         self.build()