[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added a comment.

This is complicated mainly because we are trying to merge two different register numbering scheme. On LLDB (host) side we try to construct register number from parsing register xml assigning register numbers in the increasing order. But we also have target supplied register numbers in regnum field. However registers on LLDB server side have fixed numbering although it may look like assigned in increasing order but this may not always be the case. Presence of optional register sets also doesnt help so we have the mess on managing target vs host register numbers not always in sync.

For invalidate_regs and value_regs register numbers should always be the ones assigned by remote i-e eRegisterKindProcessPlugin. So I would say this patch is ok as it corrects that info.

Broadly speaking we should do something about integrating user typed registers which may be unions of various other registers but should not require numbering.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108768/new/

https://reviews.llvm.org/D108768