[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

Mon Sep 6 06:18:25 PDT 2021

labath added a comment.

In D104231#2817068 <https://reviews.llvm.org/D104231#2817068>, @teemperor wrote:

> Not sure what else we should do to properly deprecate an API. LLVM's approach would be to put `[[deprecated("bla")]]` the C++ APIs (which would mean you need a C++14 compiler to use the SB API)

You can always put the attribute inside an `#ifdef c++14`.

Another option is to put something like `#ifdef LLDB_USE_DEPRECATED_DECLARATIONS` around these functions, forcing to user to explicitly request their usage.

Neither of these options will help the usages from python, so it's not a fully general solution, but it sounds like we don't need to worry about that right now...

> and there is also the `lldb-versioning.h` header (which seems to be reserved for actual API breakages).

wow

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104231/new/

https://reviews.llvm.org/D104231