[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

[Philip Pfaffe via Phabricator via lldb-commits]

pfaffe added a comment.

In D97786#2973868 <https://reviews.llvm.org/D97786#2973868>, @dblaikie wrote:

> This doesn't solve all use cases/it's not a terribly general purpose situation - using -fdebug-prefix-map/-fdebug-compilation-dir requires knowledge of these limitations/how to use these features together. (though I agree that changes in this area should apply to all relative comp_dir lookups - source and dwo files alike, rather than handling one group differently from the other when they're all defined as comp_dir relative)

My main concern is that even with knowledge of how the debug-compilation-dir features work, there are use cases that stop working after this change and are unfixable on the user's end. Anything that involves linking shared objects into multiple executables for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97786/new/

https://reviews.llvm.org/D97786