[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

Can you explain why we need the memory region? When we're using an SB class from the ScriptedProcess plugin, we need to be very careful to avoid introducing cyclic dependencies. The memory region seems like a pretty "dumb" class (i.e. it's basically just a few ivars with getters and setters) so it's probably fine, but we should have a comment explaining why it's fine.



================
Comment at: lldb/include/lldb/API/SBMemoryRegionInfo.h:133
 
-  lldb::MemoryRegionInfoUP m_opaque_up;
+  lldb::MemoryRegionInfoSP m_opaque_sp;
 };
----------------
Why is this necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107585/new/

https://reviews.llvm.org/D107585